Fix selector-attribute-operator-disallowed-list end positions (#6225)

stylelint · Jul 28, 2022 · e814132 · e814132
1 parent 7204f50
commit e814132
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/lib/rules/selector-attribute-operator-disallowed-list/__tests__/index.js b/lib/rules/selector-attribute-operator-disallowed-list/__tests__/index.js
@@ -47,24 +47,32 @@ testRule({
 			message: messages.rejected('~='),
 			line: 1,
 			column: 7,
+			endLine: 1,
+			endColumn: 9,
 		},
 		{
 			code: '[ title~="flower" ] { }',
 			message: messages.rejected('~='),
 			line: 1,
 			column: 8,
+			endLine: 1,
+			endColumn: 10,
 		},
 		{
 			code: '[title ~= "flower"] { }',
 			message: messages.rejected('~='),
 			line: 1,
 			column: 8,
+			endLine: 1,
+			endColumn: 10,
 		},
 		{
 			code: '[class*=te] { }',
 			message: messages.rejected('*='),
 			line: 1,
 			column: 7,
+			endLine: 1,
+			endColumn: 9,
 		},
 	],
 });

diff --git a/lib/rules/selector-attribute-operator-disallowed-list/index.js b/lib/rules/selector-attribute-operator-disallowed-list/index.js
@@ -29,29 +29,35 @@ const rule = (primary) => {
 			return;
 		}
 
-		const primaryValues = [primary].flat();
+		const primaryValues = new Set([primary].flat());
 
 		root.walkRules((ruleNode) => {
 			if (!isStandardSyntaxRule(ruleNode)) {
 				return;
 			}
 
-			if (!ruleNode.selector.includes('[') || !ruleNode.selector.includes('=')) {
+			const { selector } = ruleNode;
+
+			if (!selector.includes('[') || !selector.includes('=')) {
 				return;
 			}
 
-			parseSelector(ruleNode.selector, result, ruleNode, (selectorTree) => {
+			parseSelector(selector, result, ruleNode, (selectorTree) => {
 				selectorTree.walkAttributes((attributeNode) => {
-					const operator = attributeNode.operator;
+					const { operator } = attributeNode;
 
-					if (!operator || (operator && !primaryValues.includes(operator))) {
+					if (!operator || !primaryValues.has(operator)) {
 						return;
 					}
 
+					const index = attributeNode.sourceIndex + attributeNode.offsetOf('operator');
+					const endIndex = index + operator.length;
+
 					report({
 						message: messages.rejected(operator),
 						node: ruleNode,
-						index: attributeNode.sourceIndex + attributeNode.offsetOf('operator'),
+						index,
+						endIndex,
 						result,
 						ruleName,
 					});