Skip to content

Commit

Permalink
Fix selector-no-vendor-prefix end positions (#6261)
Browse files Browse the repository at this point in the history
  • Loading branch information
ybiquitous committed Aug 14, 2022
1 parent 43ecd9f commit d324493
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 15 deletions.
16 changes: 16 additions & 0 deletions lib/rules/selector-no-vendor-prefix/__tests__/index.js
Expand Up @@ -51,46 +51,62 @@ testRule({
message: messages.rejected(':-webkit-full-screen'),
line: 1,
column: 1,
endLine: 1,
endColumn: 21,
},
{
code: ':-wEbKiT-fUlL-sCrEeN a {}',
fixed: ':fUlL-sCrEeN a {}',
message: messages.rejected(':-wEbKiT-fUlL-sCrEeN'),
line: 1,
column: 1,
endLine: 1,
endColumn: 21,
},
{
code: ':-WEBKIT-FULL-SCREEN a {}',
fixed: ':FULL-SCREEN a {}',
message: messages.rejected(':-WEBKIT-FULL-SCREEN'),
line: 1,
column: 1,
endLine: 1,
endColumn: 21,
},
{
code: 'body, :-ms-fullscreen a {}',
fixed: 'body, :fullscreen a {}',
message: messages.rejected(':-ms-fullscreen'),
line: 1,
column: 7,
endLine: 1,
endColumn: 22,
},
{
code: 'input::-moz-placeholder, input::placeholder { color: pink; }',
fixed: 'input::placeholder, input::placeholder { color: pink; }',
message: messages.rejected('::-moz-placeholder'),
line: 1,
column: 6,
endLine: 1,
endColumn: 24,
},
{
code: 'input::-moz-placeholder { color: pink; }',
fixed: 'input::placeholder { color: pink; }',
message: messages.rejected('::-moz-placeholder'),
line: 1,
column: 6,
endLine: 1,
endColumn: 24,
},
{
code: 'input::-webkit-input-placeholder { color: pink; }',
fixed: 'input::input-placeholder { color: pink; }',
message: messages.rejected('::-webkit-input-placeholder'),
line: 1,
column: 6,
endLine: 1,
endColumn: 33,
},
],
});
Expand Down
34 changes: 19 additions & 15 deletions lib/rules/selector-no-vendor-prefix/index.js
Expand Up @@ -49,25 +49,29 @@ const rule = (primary, secondaryOptions, context) => {

parseSelector(selector, result, ruleNode, (selectorTree) => {
selectorTree.walkPseudos((pseudoNode) => {
if (isAutoprefixable.selector(pseudoNode.value)) {
if (optionsMatches(secondaryOptions, 'ignoreSelectors', pseudoNode.value)) {
return;
}
const { value } = pseudoNode;

if (context.fix) {
ruleNode.selector = isAutoprefixable.unprefix(ruleNode.selector);
if (!isAutoprefixable.selector(value)) {
return;
}

if (optionsMatches(secondaryOptions, 'ignoreSelectors', value)) {
return;
}

return;
}
if (context.fix) {
ruleNode.selector = isAutoprefixable.unprefix(selector);

report({
result,
ruleName,
message: messages.rejected(pseudoNode.value),
node: ruleNode,
index: (ruleNode.raws.before || '').length + pseudoNode.sourceIndex,
});
return;
}

report({
result,
ruleName,
message: messages.rejected(value),
node: ruleNode,
word: value,
});
});
});
});
Expand Down

0 comments on commit d324493

Please sign in to comment.