Fix TypeError for custom properties fallback in length-zero-no-unit (#…

…4860)
stylelint · Aug 10, 2020 · 9e1edfa · 9e1edfa
1 parent 1e52251
commit 9e1edfa
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/rules/length-zero-no-unit/__tests__/index.js b/lib/rules/length-zero-no-unit/__tests__/index.js
@@ -237,6 +237,10 @@ testRule({
 			code: 'a { font: normal normal 400 16px /0px cursive; }',
 			description: 'ignore line-height in font declaration',
 		},
+		{
+			code: 'a { font: var(--foo, normal normal 400 16px/0px cursive); }',
+			description: 'ignore line-height in font declaration within var function',
+		},
 		{
 			code: 'a { font: normal normal 400 1.2em cursive; }',
 			description: 'do not fail if no line-height in font declaration',
@@ -530,6 +534,13 @@ testRule({
 			line: 1,
 			column: 30,
 		},
+		{
+			code: 'a { margin: var(--foo, 0px); }',
+			fixed: 'a { margin: var(--foo, 0); }',
+			message: messages.rejected,
+			line: 1,
+			column: 25,
+		},
 	],
 });
 

diff --git a/lib/rules/length-zero-no-unit/index.js b/lib/rules/length-zero-no-unit/index.js
@@ -40,9 +40,9 @@ function rule(actual, secondary, context) {
 			const ignorableIndexes = new Array(stringValue.length).fill(false);
 			const parsedValue = valueParser(stringValue);
 
-			parsedValue.walk((node, nodeIndex) => {
+			parsedValue.walk((node, nodeIndex, nodes) => {
 				if (decl.prop.toLowerCase() === 'font' && node.type === 'div' && node.value === '/') {
-					const lineHeightNode = parsedValue.nodes[nodeIndex + 1];
+					const lineHeightNode = nodes[nodeIndex + 1];
 					const lineHeightNodeValue = valueParser.stringify(lineHeightNode);
 
 					for (let i = 0; i < lineHeightNodeValue.length; i++) {