Fix SVG tags whitelist in selector-type-no-unknown rule (#4472) (#4495)

stylelint · Dec 27, 2019 · 9cd0557 · 9cd0557
1 parent 6d92b10
commit 9cd0557
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/rules/selector-type-no-unknown/__tests__/index.js b/lib/rules/selector-type-no-unknown/__tests__/index.js
@@ -85,6 +85,10 @@ testRule(rule, {
 			code: 'circle {}',
 			description: 'svg tags',
 		},
+		{
+			code: 'foreignObject {}',
+			description: 'case-sensitive svg tags',
+		},
 		{
 			code: '@media keyframes { 0.0% {} 49.1% {} 100% {} }',
 			description: 'standard usage of keyframe selectors',

diff --git a/lib/rules/selector-type-no-unknown/index.js b/lib/rules/selector-type-no-unknown/index.js
@@ -87,7 +87,8 @@ const rule = function(actual, options) {
 
 					if (
 						htmlTags.includes(tagNameLowerCase) ||
-						svgTags.includes(tagNameLowerCase) ||
+						// SVG tags are case-sensitive
+						svgTags.includes(tagName) ||
 						keywordSets.nonStandardHtmlTags.has(tagNameLowerCase) ||
 						mathMLTags.includes(tagNameLowerCase)
 					) {