Skip to content

Commit

Permalink
Check all reported warnings in tests (#4256)
Browse files Browse the repository at this point in the history 
* block-closing-brace-space-before
* block-opening-brace-newline-before
* function-parentheses-newline-inside
* media-query-list-comma-newline-after
* rule-empty-line-before
* selector-attribute-brackets-space-inside
* selector-attribute-operator-space-after
* selector-attribute-operator-space-before
* selector-combinator-space-after
* selector-list-comma-newline-after
* selector-max-combinators
  • Loading branch information
@vankop @hudochenkov
vankop authored and hudochenkov committed Sep 5, 2019
1 parent e89c6c0 commit 60a4b8c
Show file tree
Hide file tree
Showing 11 changed files with 476 additions and 114 deletions.
30 changes: 24 additions & 6 deletions lib/rules/block-closing-brace-space-before/__tests__/index.js
View file
Expand Up @@ -67,9 +67,18 @@ testRule(rule, {
{
code: "a { color: pink;} b { color: red;}",
fixed: "a { color: pink; } b { color: red; }",
message: messages.expectedBefore(),
line: 1,
column: 16
warnings: [
{
message: messages.expectedBefore(),
line: 1,
column: 16
},
{
message: messages.expectedBefore(),
line: 1,
column: 33
}
]
},
{
code: "a { color: pink;/*comment*/}",
Expand Down Expand Up @@ -152,9 +161,18 @@ testRule(rule, {
{
code: "a { color: pink; } b { color: red; }",
fixed: "a { color: pink;} b { color: red;}",
message: messages.rejectedBefore(),
line: 1,
column: 17
warnings: [
{
message: messages.rejectedBefore(),
line: 1,
column: 17
},
{
message: messages.rejectedBefore(),
line: 1,
column: 35
}
]
},
{
code: "a { color: pink; /*comment*/ }",
Expand Down
15 changes: 12 additions & 3 deletions lib/rules/block-opening-brace-newline-before/__tests__/index.js
View file
Expand Up @@ -159,9 +159,18 @@ testRule(rule, {
{
code: "@media print /* foo */ { a /* foo */ { color: pink; } }",
fixed: "@media print /* foo */\n { a /* foo */\n { color: pink; } }",
message: messages.expectedBefore(),
line: 1,
column: 37
warnings: [
{
message: messages.expectedBefore(),
line: 1,
column: 37
},
{
message: messages.expectedBefore(),
line: 1,
column: 23
}
]
}
]
});
Expand Down
75 changes: 60 additions & 15 deletions lib/rules/function-parentheses-newline-inside/__tests__/index.js
View file
Expand Up @@ -128,9 +128,18 @@ testRule(rule, {
code: "a { transform: translate( /*c1*/ /*c2*/ 1,1 /*c3*/ /*c4*/ ); }",
fixed:
"a { transform: translate( /*c1*/ /*c2*/\n 1,1 /*c3*/ /*c4*/\n ); }",
message: messages.expectedOpening,
line: 1,
column: 26
warnings: [
{
message: messages.expectedOpening,
line: 1,
column: 26
},
{
message: messages.expectedClosing,
line: 1,
column: 58
}
]
}
]
});
Expand Down Expand Up @@ -342,30 +351,66 @@ testRule(rule, {
{
code: "a { transform: translate( /*c1*/ /*c2*/ 1,\n1 /*c3*/ /*c4*/ ); }",
fixed: "a { transform: translate(/*c1*//*c2*/1,\n1/*c3*//*c4*/); }",
message: messages.rejectedOpeningMultiLine,
line: 1,
column: 26
warnings: [
{
message: messages.rejectedOpeningMultiLine,
line: 1,
column: 26
},
{
message: messages.rejectedClosingMultiLine,
line: 2,
column: 16
}
]
},
{
code: "a { transform: translate( /*c1*//*c2*/1,\n1/*c3*//*c4*/ ); }",
fixed: "a { transform: translate(/*c1*//*c2*/1,\n1/*c3*//*c4*/); }",
message: messages.rejectedOpeningMultiLine,
line: 1,
column: 26
warnings: [
{
message: messages.rejectedOpeningMultiLine,
line: 1,
column: 26
},
{
message: messages.rejectedClosingMultiLine,
line: 2,
column: 14
}
]
},
{
code: "a { transform: translate(/*c1*//*c2*/ 1,\n1 /*c3*//*c4*/); }",
fixed: "a { transform: translate(/*c1*//*c2*/1,\n1/*c3*//*c4*/); }",
message: messages.rejectedOpeningMultiLine,
line: 1,
column: 26
warnings: [
{
message: messages.rejectedOpeningMultiLine,
line: 1,
column: 26
},
{
message: messages.rejectedClosingMultiLine,
line: 2,
column: 14
}
]
},
{
code: "a { transform: translate(/*c1*/ /*c2*/1,\n1/*c3*/ /*c4*/); }",
fixed: "a { transform: translate(/*c1*//*c2*/1,\n1/*c3*//*c4*/); }",
message: messages.rejectedOpeningMultiLine,
line: 1,
column: 26
warnings: [
{
message: messages.rejectedOpeningMultiLine,
line: 1,
column: 26
},
{
message: messages.rejectedClosingMultiLine,
line: 2,
column: 14
}
]
}
]
});
48 changes: 38 additions & 10 deletions lib/rules/media-query-list-comma-newline-after/__tests__/index.js
View file
Expand Up @@ -183,11 +183,25 @@ testRule(rule, {
column: 26
},
{
code: "@media " + "tv,".repeat(50) + "print {}",
fixed: "@media " + "tv,\n".repeat(50) + "print {}",
message: messages.expectedAfter(),
line: 1,
column: 10
code: "@media tv,tv,tv,print {}",
fixed: "@media tv,\ntv,\ntv,\nprint {}",
warnings: [
{
message: messages.expectedAfter(),
line: 1,
column: 10
},
{
message: messages.expectedAfter(),
line: 1,
column: 13
},
{
message: messages.expectedAfter(),
line: 1,
column: 16
}
]
}
]
});
Expand Down Expand Up @@ -398,11 +412,25 @@ testRule(rule, {
column: 26
},
{
code: "@media " + "tv,\n".repeat(50) + "print {\n}",
fixed: "@media " + "tv,".repeat(50) + "print {\n}",
message: messages.rejectedAfterMultiLine(),
line: 1,
column: 10
code: "@media tv,\ntv,\ntv,\nprint {\n}",
fixed: "@media tv,tv,tv,print {\n}",
warnings: [
{
message: messages.rejectedAfterMultiLine(),
line: 1,
column: 10
},
{
message: messages.rejectedAfterMultiLine(),
line: 2,
column: 3
},
{
message: messages.rejectedAfterMultiLine(),
line: 3,
column: 3
}
]
}
]
});
Expand Down
26 changes: 24 additions & 2 deletions lib/rules/rule-empty-line-before/__tests__/index.js
View file
Expand Up @@ -66,7 +66,18 @@ testRule(rule, {
code: "@media { b {}\n\n/* comment here*/\na {} }",
fixed: "@media {\n\n b {}\n\n/* comment here*/\n\na {} }",
description: "nested",
message: messages.expected
warnings: [
{
message: messages.expected,
line: 1,
column: 10
},
{
message: messages.expected,
line: 4,
column: 1
}
]
}
]
});
Expand Down Expand Up @@ -103,7 +114,18 @@ testRule(rule, {
{
code: "@media { b {} a {} }",
fixed: "@media {\n\n b {}\n\n a {} }",
message: messages.expected
warnings: [
{
message: messages.expected,
line: 1,
column: 10
},
{
message: messages.expected,
line: 1,
column: 15
}
]
}
]
});
Expand Down

0 comments on commit 60a4b8c

Please sign in to comment.