Apply suggestions from code review

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
stylelint · Feb 26, 2021 · 5af0f16 · 5af0f16
1 parent bead6f3
commit 5af0f16
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 25 deletions.
diff --git a/lib/rules/declaration-block-trailing-semicolon/README.md b/lib/rules/declaration-block-trailing-semicolon/README.md
@@ -99,27 +99,10 @@ The following patterns are _not_ considered violations:
 
 <!-- prettier-ignore -->
 ```css
-foo { property: value }
-```
-
-<!-- prettier-ignore -->
-```css
-foo { property: value; }
-```
-
-<!-- prettier-ignore -->
-```css
-@keyframes name { from { property: 0 } to { property: 1; } }
+a { color: pink }
 ```
 
-With `"always"`:
-
-The following pattern is _still_ considered a violation:
-
 <!-- prettier-ignore -->
 ```css
-foo {
-  property: value;
-  bar: qux
-}
+a { color: pink; }
 ```
diff --git a/lib/rules/declaration-block-trailing-semicolon/__tests__/index.js b/lib/rules/declaration-block-trailing-semicolon/__tests__/index.js
@@ -69,15 +69,15 @@ testRule({
 
 	accept: [
 		{
-			code: 'foo { property: value }',
+			code: 'a { color: pink }',
 			description: 'single declaration without trailing semicolon',
 		},
 		{
-			code: 'foo { property: value; }',
+			code: 'a { color: pink; }',
 			description: 'single declaration with trailing semicolon',
 		},
 		{
-			code: '@keyframes name { from { property: 0 } to { property: 1; } }',
+			code: '@keyframes foo { from { top: 0px } to { top: 1px; } }',
 			description: 'inconsistent case (with and without)',
 		},
 	],
@@ -100,15 +100,15 @@ testRule({
 
 	accept: [
 		{
-			code: 'foo { property: value }',
+			code: 'a { color: pink }',
 			description: 'single declaration without trailing semicolon',
 		},
 		{
-			code: 'foo { property: value; }',
+			code: 'a { color: pink; }',
 			description: 'single declaration with trailing semicolon',
 		},
 		{
-			code: '@keyframes name { from { property: 0 } to { property: 1; } }',
+			code: '@keyframes foo { from { top: 0px } to { top: 1px; } }',
 			description: 'inconsistent case (with and without)',
 		},
 	],