Fix false positives for flex in length-zero-no-unit (#5315)

stylelint · May 19, 2021 · 52a67ab · 52a67ab
1 parent a3460ef
commit 52a67ab
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/rules/length-zero-no-unit/__tests__/index.js b/lib/rules/length-zero-no-unit/__tests__/index.js
@@ -220,6 +220,14 @@ testRule({
 		{
 			code: 'a { lIne-hEight: 0px; }',
 		},
+		{
+			code: 'a { flex: 0px; }',
+			description: 'ignore flex property',
+		},
+		{
+			code: 'a { Flex: 0px; }',
+			description: 'ignore cased flex property',
+		},
 		{
 			code: 'a { grid-auto-columns: 0fr; }',
 			description: 'ignore some grid properties with `fr`',

diff --git a/lib/rules/length-zero-no-unit/index.js b/lib/rules/length-zero-no-unit/index.js
@@ -107,6 +107,8 @@ function rule(primary, secondary, context) {
 
 			if (isLineHeight(prop)) return;
 
+			if (isFlex(prop)) return;
+
 			if (optionsMatches(secondary, 'ignore', 'custom-properties') && isCustomProperty(prop))
 				return;
 
@@ -142,6 +144,10 @@ function isLineHeight(prop) {
 	return prop.toLowerCase() === 'line-height';
 }
 
+function isFlex(prop) {
+	return prop.toLowerCase() === 'flex';
+}
+
 function isWord({ type }) {
 	return type === 'word';
 }