Add ignoreFunctions: [] to length-zero-no-unit (#5314)

stylelint · May 19, 2021 · 492ae33 · 492ae33
1 parent 9152ab4
commit 492ae33
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 0 deletions.
diff --git a/lib/rules/length-zero-no-unit/README.md b/lib/rules/length-zero-no-unit/README.md
@@ -67,3 +67,23 @@ The following pattern is _not_ considered a violation:
 ```css
 a { --x: 0px; }
 ```
+
+### `ignoreFunctions: ["/regex/", /regex/, "string"]`
+
+Given:
+
+```json
+["var", "/^--/"]
+```
+
+The following patterns are _not_ considered violations:
+
+<!-- prettier-ignore -->
+```css
+a { top: var(--foo, 0px); }
+```
+
+<!-- prettier-ignore -->
+```css
+a { top: --bar(0px); }
+```
diff --git a/lib/rules/length-zero-no-unit/__tests__/index.js b/lib/rules/length-zero-no-unit/__tests__/index.js
@@ -608,6 +608,30 @@ testRule({
 	],
 });
 
+testRule({
+	ruleName,
+	config: [true, { ignoreFunctions: ['var', /^--/] }],
+	fix: true,
+	accept: [
+		{
+			code: 'a { top: var(--foo, 0px); }',
+		},
+		{
+			code: 'a { top: --bar(0px); }',
+		},
+	],
+	reject: [
+		{
+			code: 'a { margin: var(--foo, 0px) 0px --bar(0px); }',
+			fixed: 'a { margin: var(--foo, 0px) 0 --bar(0px); }',
+
+			message: messages.rejected,
+			line: 1,
+			column: 30,
+		},
+	],
+});
+
 testRule({
 	ruleName,
 	config: [true],

diff --git a/lib/rules/length-zero-no-unit/index.js b/lib/rules/length-zero-no-unit/index.js
@@ -2,6 +2,7 @@
 
 'use strict';
 
+const _ = require('lodash');
 const valueParser = require('postcss-value-parser');
 
 const atRuleParamIndex = require('../../utils/atRuleParamIndex');
@@ -37,6 +38,7 @@ function rule(primary, secondary, context) {
 				actual: secondary,
 				possible: {
 					ignore: ['custom-properties'],
+					ignoreFunctions: [_.isString, _.isRegExp],
 				},
 				optional: true,
 			},
@@ -51,6 +53,9 @@ function rule(primary, secondary, context) {
 
 			if (isMathFunction(valueNode)) return false;
 
+			if (isFunction(valueNode) && optionsMatches(secondary, 'ignoreFunctions', value))
+				return false;
+
 			if (!isWord(valueNode)) return;
 
 			const numberUnit = valueParser.unit(value);
@@ -156,6 +161,10 @@ function isLength(unit) {
 	return keywordSets.lengthUnits.has(unit.toLowerCase());
 }
 
+function isFunction({ type }) {
+	return type === 'function';
+}
+
 function isFraction(unit) {
 	return unit.toLowerCase() === 'fr';
 }