Fix false positives for functions inside of math functions in length-…

…zero-no-unit rule (#5245)
stylelint · Apr 20, 2021 · 44c28c6 · 44c28c6
1 parent 3be03b9
commit 44c28c6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/lib/rules/length-zero-no-unit/__tests__/index.js b/lib/rules/length-zero-no-unit/__tests__/index.js
@@ -28,8 +28,12 @@ testRule({
 			description: 'ignore calc. several `calc`s',
 		},
 		{
-			code: 'padding: calc(var(--foo, 0) + 10px) 0',
-			description: 'ignore calc, but not inner functions',
+			code: 'padding: calc(var(--foo, 0px) + 10px) 0',
+			description: 'ignore calc, and inner functions',
+		},
+		{
+			code: 'padding: max(10px, var(--foo, 0px)) 0',
+			description: 'ignore max, and inner functions',
 		},
 		{
 			code: 'a { right: max(100vw, 0rem)); }',
@@ -353,16 +357,11 @@ testRule({
 			column: 27,
 		},
 		{
-			description: 'ignore calc, but not inner functions',
+			description: 'ignore calc, and inner functions',
 			code: 'padding: calc(var(--foo, 0in) + 10px) 0px;',
-			fixed: 'padding: calc(var(--foo, 0) + 10px) 0;',
+			fixed: 'padding: calc(var(--foo, 0in) + 10px) 0;',
 
 			warnings: [
-				{
-					message: messages.rejected,
-					line: 1,
-					column: 27,
-				},
 				{
 					message: messages.rejected,
 					line: 1,

diff --git a/lib/rules/length-zero-no-unit/index.js b/lib/rules/length-zero-no-unit/index.js
@@ -62,6 +62,10 @@ function rule(actual, secondary, context) {
 				for (let i = 0; i < nodeValue.length; i++) {
 					ignorableIndexes[node.sourceIndex + i] = ignoreFlag;
 				}
+
+				if (isMathFunction) {
+					return false;
+				}
 			});
 
 			check(stringValue, decl, ignorableIndexes);