Fix false positives for objects in declaration-block-trailing-semicol…

…on (#4749)
stylelint · May 16, 2020 · 38968c7 · 38968c7
1 parent 8870cef
commit 38968c7
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/lib/rules/declaration-block-trailing-semicolon/__tests__/index.js b/lib/rules/declaration-block-trailing-semicolon/__tests__/index.js
@@ -171,3 +171,28 @@ testRule({
 		},
 	],
 });
+
+testRule({
+	ruleName,
+	config: ['always'],
+	syntax: 'css-in-js',
+	fix: true,
+
+	accept: [
+		{
+			code: 'const C = () => { return <a style={{ color: "red" }}></a> }',
+			description: 'css-in-js object',
+		},
+	],
+
+	reject: [
+		{
+			code: 'const C = styled.a`color: red`;',
+			fixed: 'const C = styled.a`color: red;`;',
+			description: 'css-in-js template literal',
+			message: messages.expected,
+			line: 1,
+			column: 29,
+		},
+	],
+});
diff --git a/lib/rules/declaration-block-trailing-semicolon/index.js b/lib/rules/declaration-block-trailing-semicolon/index.js
@@ -42,6 +42,10 @@ function rule(expectation, _, context) {
 		});
 
 		root.walkDecls((decl) => {
+			if (decl.parent.type === 'object') {
+				return;
+			}
+
 			if (decl !== decl.parent.last) {
 				return;
 			}