Skip to content

Commit

Permalink
Drop Node 10 support for ESM (#5303)
Browse files Browse the repository at this point in the history
This change is a part of the next major version (v14).

- Remove Node 10 from CI
- Update `engines.node`

In addition, this removes needless `CI: true` (just a refactoring).
See <https://github.blog/changelog/2020-04-15-github-actions-sets-the-ci-environment-variable-to-true/>
  • Loading branch information
ybiquitous committed May 14, 2021
1 parent 0b3fa84 commit 37e1190
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/linting.yml
Expand Up @@ -9,9 +9,6 @@ on:
branches:
- '**'

env:
CI: true

jobs:
lint:
name: Lint on Node.js ${{ matrix.node }} and ${{ matrix.os }}
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/testing.yml
Expand Up @@ -9,9 +9,6 @@ on:
branches:
- '**'

env:
CI: true

jobs:
test:
name: Test on Node.js ${{ matrix.node }} and ${{ matrix.os }}
Expand All @@ -21,7 +18,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [10, 12, 14, 16]
node: [12, 14, 16]
os: [ubuntu-latest, windows-latest, macos-latest]
exclude:
- os: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -191,6 +191,6 @@
"typescript": "^4.2.4"
},
"engines": {
"node": ">=10.13.0"
"node": "^12.20.0 || ^14.13.1 || >=16.0.0"
}
}

0 comments on commit 37e1190

Please sign in to comment.