Add ranges for warnings (#5725)

stylelint · Apr 11, 2022 · 1d94bb0 · 1d94bb0
1 parent 238f917
commit 1d94bb0
Show file tree

Hide file tree

Showing 104 changed files with 1,845 additions and 163 deletions.
diff --git a/.gitignore b/.gitignore
@@ -3,3 +3,4 @@ node_modules
 .coverage
 .eslintcache
 yarn.lock
+.vscode/settings.json
diff --git a/docs/developer-guide/formatters.md b/docs/developer-guide/formatters.md
@@ -23,6 +23,8 @@ Where the first argument (`results`) is an array of Stylelint result objects (ty
     {
       "line": 3,
       "column": 12,
+      "endLine": 4,
+      "endColumn": 15,
       "rule": "block-no-empty",
       "severity": "error",
       "text": "You should not have an empty block (block-no-empty)"

diff --git a/docs/developer-guide/plugins.md b/docs/developer-guide/plugins.md
@@ -155,7 +155,9 @@ testRule({
       fixed: ".my-class {}",
       message: messages.expected(),
       line: 1,
-      column: 1
+      column: 1,
+      endLine: 1,
+      endColumn: 9
     }
   ]
 });
@@ -266,7 +268,9 @@ function myPluginRule(primaryOption, secondaryOptionObject) {
           result: postcssResult,
           node: warning.node,
           line: warning.line,
-          column: warning.column
+          column: warning.column,
+          endLine: warning.endLine,
+          endColumn: warning.endColumn
         });
       }
     );

diff --git a/lib/__tests__/descriptionlessDisables.test.js b/lib/__tests__/descriptionlessDisables.test.js
@@ -45,20 +45,26 @@ it('descriptionlessDisables', async () => {
 		{
 			line: 12,
 			column: 1,
+			endLine: 12,
+			endColumn: 23,
 			rule: '--report-descriptionless-disables',
 			severity: 'error',
 			text: 'Disable for "all" is missing a description',
 		},
 		{
 			line: 16,
 			column: 7,
+			endLine: 16,
+			endColumn: 49,
 			rule: '--report-descriptionless-disables',
 			severity: 'error',
 			text: 'Disable for "block-no-empty" is missing a description',
 		},
 		{
 			line: 18,
 			column: 1,
+			endLine: 18,
+			endColumn: 48,
 			rule: '--report-descriptionless-disables',
 			severity: 'error',
 			text: 'Disable for "block-no-empty" is missing a description',
@@ -108,20 +114,26 @@ it('descriptionlessDisables from config', async () => {
 		{
 			line: 12,
 			column: 1,
+			endLine: 12,
+			endColumn: 23,
 			rule: '--report-descriptionless-disables',
 			severity: 'error',
 			text: 'Disable for "all" is missing a description',
 		},
 		{
 			line: 16,
 			column: 7,
+			endLine: 16,
+			endColumn: 49,
 			rule: '--report-descriptionless-disables',
 			severity: 'error',
 			text: 'Disable for "block-no-empty" is missing a description',
 		},
 		{
 			line: 18,
 			column: 1,
+			endLine: 18,
+			endColumn: 48,
 			rule: '--report-descriptionless-disables',
 			severity: 'error',
 			text: 'Disable for "block-no-empty" is missing a description',
@@ -171,13 +183,17 @@ it('descriptionlessDisables true except', async () => {
 		{
 			line: 12,
 			column: 1,
+			endLine: 12,
+			endColumn: 23,
 			rule: '--report-descriptionless-disables',
 			severity: 'error',
 			text: 'Disable for "all" is missing a description',
 		},
 		{
 			line: 18,
 			column: 1,
+			endLine: 18,
+			endColumn: 48,
 			rule: '--report-descriptionless-disables',
 			severity: 'error',
 			text: 'Disable for "block-no-empty" is missing a description',
@@ -227,6 +243,8 @@ it('descriptionlessDisables false except', async () => {
 		{
 			line: 16,
 			column: 7,
+			endLine: 16,
+			endColumn: 51,
 			rule: '--report-descriptionless-disables',
 			severity: 'error',
 			text: 'Disable for "invalid-hex-case" is missing a description',
@@ -276,20 +294,26 @@ it('descriptionlessDisables severity', async () => {
 		{
 			line: 12,
 			column: 1,
+			endLine: 12,
+			endColumn: 23,
 			rule: '--report-descriptionless-disables',
 			severity: 'warning',
 			text: 'Disable for "all" is missing a description',
 		},
 		{
 			line: 16,
 			column: 7,
+			endLine: 16,
+			endColumn: 49,
 			rule: '--report-descriptionless-disables',
 			severity: 'warning',
 			text: 'Disable for "block-no-empty" is missing a description',
 		},
 		{
 			line: 18,
 			column: 1,
+			endLine: 18,
+			endColumn: 48,
 			rule: '--report-descriptionless-disables',
 			severity: 'warning',
 			text: 'Disable for "block-no-empty" is missing a description',

diff --git a/lib/__tests__/invalidScopeDisables.test.js b/lib/__tests__/invalidScopeDisables.test.js
@@ -38,13 +38,17 @@ it('invalidScopeDisables simple case', async () => {
 		{
 			line: 1,
 			column: 1,
+			endLine: 1,
+			endColumn: 38,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "block-no-empty" isn\'t enabled',
 			severity: 'error',
 		},
 		{
 			line: 5,
 			column: 7,
+			endLine: 5,
+			endColumn: 49,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "block-no-empty" isn\'t enabled',
 			severity: 'error',
@@ -80,13 +84,17 @@ it('invalidScopeDisables from config', async () => {
 		{
 			line: 1,
 			column: 1,
+			endLine: 1,
+			endColumn: 38,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "block-no-empty" isn\'t enabled',
 			severity: 'error',
 		},
 		{
 			line: 5,
 			column: 7,
+			endLine: 5,
+			endColumn: 49,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "block-no-empty" isn\'t enabled',
 			severity: 'error',
@@ -117,6 +125,8 @@ it('invalidScopeDisables complex case', async () => {
 		{
 			line: 1,
 			column: 1,
+			endLine: 1,
+			endColumn: 35,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "color-named" isn\'t enabled',
 			severity: 'error',
@@ -126,6 +136,8 @@ it('invalidScopeDisables complex case', async () => {
 		{
 			line: 5,
 			column: 6,
+			endLine: 5,
+			endColumn: 45,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "color-named" isn\'t enabled',
 			severity: 'error',
@@ -154,6 +166,8 @@ it('invalidScopeDisables ignored case', async () => {
 		{
 			line: 5,
 			column: 1,
+			endLine: 5,
+			endColumn: 38,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "block-no-empty" isn\'t enabled',
 			severity: 'error',
@@ -186,6 +200,8 @@ it('invalidScopeDisables for config file', async () => {
 		{
 			line: 4,
 			column: 1,
+			endLine: 4,
+			endColumn: 27,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "foo" isn\'t enabled',
 			severity: 'error',
@@ -221,6 +237,8 @@ it('invalidScopeDisables true except', async () => {
 		{
 			line: 1,
 			column: 1,
+			endLine: 1,
+			endColumn: 38,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "block-no-empty" isn\'t enabled',
 			severity: 'error',
@@ -256,6 +274,8 @@ it('invalidScopeDisables false except', async () => {
 		{
 			line: 5,
 			column: 7,
+			endLine: 5,
+			endColumn: 51,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "invalid-hex-case" isn\'t enabled',
 			severity: 'error',
@@ -291,13 +311,17 @@ it('invalidScopeDisables severity', async () => {
 		{
 			line: 1,
 			column: 1,
+			endLine: 1,
+			endColumn: 38,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "block-no-empty" isn\'t enabled',
 			severity: 'warning',
 		},
 		{
 			line: 5,
 			column: 7,
+			endLine: 5,
+			endColumn: 49,
 			rule: '--report-invalid-scope-disables',
 			text: 'Rule "block-no-empty" isn\'t enabled',
 			severity: 'warning',