Skip to content

Commit

Permalink
Fix selector-pseudo-class-disallowed-list end positions and message (
Browse files Browse the repository at this point in the history
  • Loading branch information
ybiquitous committed Aug 14, 2022
1 parent 67f509c commit 151a654
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 17 deletions.
56 changes: 42 additions & 14 deletions lib/rules/selector-pseudo-class-disallowed-list/__tests__/index.js
Expand Up @@ -64,33 +64,43 @@ testRule({
reject: [
{
code: 'a:focus {}',
message: messages.rejected('focus'),
message: messages.rejected(':focus'),
line: 1,
column: 2,
endLine: 1,
endColumn: 8,
},
{
code: 'a,\n:global {}',
message: messages.rejected('global'),
message: messages.rejected(':global'),
line: 2,
column: 1,
endLine: 2,
endColumn: 8,
},
{
code: 'input:-ms-input-placeholder {}',
message: messages.rejected('-ms-input-placeholder'),
message: messages.rejected(':-ms-input-placeholder'),
line: 1,
column: 6,
endLine: 1,
endColumn: 28,
},
{
code: 'a:not(::selection) {}',
message: messages.rejected('not'),
message: messages.rejected(':not'),
line: 1,
column: 2,
endLine: 1,
endColumn: 6,
},
{
code: 'a:has(> img) {}',
message: messages.rejected('has'),
message: messages.rejected(':has'),
line: 1,
column: 2,
endLine: 1,
endColumn: 6,
},
],
});
Expand All @@ -114,15 +124,19 @@ testRule({
reject: [
{
code: 'a:last-child {}',
message: messages.rejected('last-child'),
message: messages.rejected(':last-child'),
line: 1,
column: 2,
endLine: 1,
endColumn: 13,
},
{
code: 'a:last-of-child {}',
message: messages.rejected('last-of-child'),
message: messages.rejected(':last-of-child'),
line: 1,
column: 2,
endLine: 1,
endColumn: 16,
},
],
});
Expand All @@ -140,9 +154,11 @@ testRule({
reject: [
{
code: 'a:last-child {}',
message: messages.rejected('last-child'),
message: messages.rejected(':last-child'),
line: 1,
column: 2,
endLine: 1,
endColumn: 13,
},
],
});
Expand All @@ -160,42 +176,54 @@ testRule({
reject: [
{
code: 'a:not() {}',
message: messages.rejected('not'),
message: messages.rejected(':not'),
line: 1,
column: 2,
endLine: 1,
endColumn: 6,
},
{
code: 'body:not(div):has(span) {}',
warnings: [
{
message: messages.rejected('not'),
message: messages.rejected(':not'),
line: 1,
column: 5,
endLine: 1,
endColumn: 9,
},
{
message: messages.rejected('has'),
message: messages.rejected(':has'),
line: 1,
column: 14,
endLine: 1,
endColumn: 18,
},
],
},
{
code: 'body:nt(div):not(span) {}',
message: messages.rejected('not'),
message: messages.rejected(':not'),
line: 1,
column: 13,
endLine: 1,
endColumn: 17,
},
{
code: 'a:has() {}',
message: messages.rejected('has'),
message: messages.rejected(':has'),
line: 1,
column: 2,
endLine: 1,
endColumn: 6,
},
{
code: 'a:matches() {}',
message: messages.rejected('matches'),
message: messages.rejected(':matches'),
line: 1,
column: 2,
endLine: 1,
endColumn: 10,
},
],
});
Expand Down
5 changes: 2 additions & 3 deletions lib/rules/selector-pseudo-class-disallowed-list/index.js
Expand Up @@ -47,7 +47,6 @@ const rule = (primary) => {
const value = pseudoNode.value;

// Ignore pseudo-elements

if (value.slice(0, 2) === '::') {
return;
}
Expand All @@ -59,8 +58,8 @@ const rule = (primary) => {
}

report({
index: pseudoNode.sourceIndex,
message: messages.rejected(name),
word: value,
message: messages.rejected(value),
node: ruleNode,
result,
ruleName,
Expand Down

0 comments on commit 151a654

Please sign in to comment.