Fix crash in block-no-empty (#4110)

* Fix crash in block-no-empty `block-no-empty` should allow `@import` statements, but it's currently crashing with error "Cannot read property 'every' of undefined" * use hasBlock helper
stylelint · Jun 22, 2019 · 0bbe61f · 0bbe61f
1 parent 46b3a44
commit 0bbe61f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/rules/block-no-empty/__tests__/index.js b/lib/rules/block-no-empty/__tests__/index.js
@@ -133,6 +133,9 @@ testRule(rule, {
     },
     {
       code: "a {\n/* foo */\ncolor: pink;\n}"
+    },
+    {
+      code: '@import "foo.css";'
     }
   ],
 

diff --git a/lib/rules/block-no-empty/index.js b/lib/rules/block-no-empty/index.js
@@ -2,6 +2,7 @@
 
 const _ = require("lodash");
 const beforeBlockString = require("../../utils/beforeBlockString");
+const hasBlock = require("../../utils/hasBlock");
 const hasEmptyBlock = require("../../utils/hasEmptyBlock");
 const optionsMatches = require("../../utils/optionsMatches");
 const report = require("../../utils/report");
@@ -47,6 +48,10 @@ const rule = function(primary, options = {}) {
         return;
       }
 
+      if (!hasBlock(statement)) {
+        return;
+      }
+
       const hasCommentsOnly = statement.nodes.every(
         node => node.type === "comment"
       );