Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom parameter messages to *-pattern rules #264

Merged
merged 3 commits into from Oct 15, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Oct 3, 2022

Which issue, if any, is this issue related to?

Closes #263
Wait for stylelint/stylelint#6391

Is there anything in the PR that needs further explanation?

This PR installs the development version of stylelint, so we cannot merge for now.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
beforeEach(() => {
result = stylelint.lint({
beforeEach(async () => {
result = await stylelint.lint({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] The change uses async/await to simplify the test code.

@ybiquitous ybiquitous marked this pull request as ready for review October 13, 2022 16:53
@ybiquitous ybiquitous added the pr: blocked is blocked by another issue or pr label Oct 13, 2022
@jeddy3 jeddy3 changed the title Improve custom messages via formatting Add custom parameter messages to *-pattern rules Oct 13, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Feel free to merge after the peer and dep stylelint deps are updated.

@jeddy3 jeddy3 removed the pr: blocked is blocked by another issue or pr label Oct 14, 2022
@ybiquitous ybiquitous merged commit dd1ce5c into main Oct 15, 2022
@ybiquitous ybiquitous deleted the improve-custom-messages branch October 15, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use parameterized custom messages
2 participants