This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
Fix computed property name in Object Styles #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for this! |
|
Oops looks like we've dropped the ball on merging this PR - @stylelint/css-in-js I'm not as familiar with the codebase, any thoughts? |
|
There's an investigative piece going on around updating to PostCSS 8. It might be that this pull request needs to wait until after that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36.
Actually, the result goes wrong when the property key looks like
[Identifier].The keys such as
[`${Identifier} > span`]and"&:before"have been parsed correctly already (tested in glamorous test fixture).