Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add only and skip for test groups #33

Merged
merged 1 commit into from May 15, 2021
Merged

Conversation

ybiquitous
Copy link
Member

This change adds only and skip options to run only a test group or skip a test group.

For example:

testRule({
  ruleName,
  only: true,  // added
  skip: true,  // added
  accept: [ /* ... */ ],
  reject: [ /* ... */ ],
});

Which issue, if any, is this issue related to?

Related to stylelint/stylelint#5297
I believe this change will provide a better way than commenting out.

Is there anything in the PR that needs further explanation?

In addition, I've added JSDoc (#15) to understand the whole test options (it might not be sufficient, though).
I can remove it if anyone hopes to minimize the change.

This change adds `only` and `skip` options to run only a test group or skip a test group.

For example:

```js
testRule({
  ruleName,
  only: true,  // added
  skip: true,  // added
  accept: [ /* ... */ ],
  reject: [ /* ... */ ],
});
```
@ybiquitous ybiquitous marked this pull request as ready for review May 15, 2021 02:36
* @property {boolean} [fix]
* @property {Syntax} [customSyntax] - PostCSS Syntax (https://postcss.org/api/#syntax)
* @property {boolean} [only]
* @property {boolean} [skip]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] This change adds the only and skip options above.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@jeddy3 jeddy3 merged commit 0325710 into master May 15, 2021
@jeddy3 jeddy3 deleted the add-test-group-only-and-skip branch May 15, 2021 06:44
@jeddy3
Copy link
Member

jeddy3 commented May 15, 2021

  • Added: only and skip to test group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants