Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support at-rules in no-global-function-names #988

Merged
merged 4 commits into from May 2, 2024
Merged

Support at-rules in no-global-function-names #988

merged 4 commits into from May 2, 2024

Conversation

FloEdelmann
Copy link
Contributor

Fixes #593.

@kristerkari
Copy link
Collaborator

Thanks! Looks really good, but there is just one small thing that needs to be changed in my opinion. 👍

kristerkari
kristerkari approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@kristerkari kristerkari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kristerkari kristerkari merged commit 90caa27 into stylelint-scss:master May 2, 2024
5 checks passed
@FloEdelmann FloEdelmann deleted the no-global-function-names branch May 2, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristerkari kristerkari kristerkari approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-global-function-names doesn't report errors inside of @if statements.. it works fine otherwise
2 participants
@FloEdelmann @kristerkari