Make scss/comment-no-empty treat multiline double-slash comments as blocks
#607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #606
I've never contributed to a stylelint rule before, so apologies if I've made any structural mistakes here. In particular, I felt a bit uncertain about adding state that persists between different calls to the
walkCommentscallback, since I didn't see other examples of rules doing that, but it seemed like the most straightforward way to solve the problem.The logic for determining whether a given comment is double-slash vs not and standalone vs not is taken from the examples on L44-51 of
src/rules/double-slash-comment-empty-line-before/index.js.