New rule: No non numeric dimensions

src/rules/no-non-numeric-dimensions/README.md

@@ -91,6 +91,3 @@ Resolution units ([link](https://www.w3.org/TR/css-values-4/#resolution))
 
 Flexible lengths ([link](https://www.w3.org/TR/css-grid-1/#fr-unit))
 * fr
-
-Percentage ([link](https://www.w3.org/TR/css-values-4/#percentages))
-* %

src/rules/no-non-numeric-dimensions/__tests__/index.js

@@ -7,7 +7,7 @@ testRule(rule, {
   accept: loopOverUnits({
     code: `
     p {
-      padding: "1" * 1%unit%;
+      padding: 1 * 1%unit%;
     }
     `,
     description: "Accepts proper value interpolation with %unit%"
@@ -19,6 +19,11 @@ testRule(rule, {
     {
       code: "$pad: 2; $doublePad: #{$pad}pxx;",
       description: "does not report lint when no understood units are used"
+    },
+    {
+      code: `$pad: "2";
+      $string: "#{$pad}px";`,
+      description: "does not report lint when no understood units are used"
     }
   ]),
   reject: loopOverUnits({

src/rules/no-non-numeric-dimensions/index.js

@@ -5,7 +5,8 @@ import valueParser from "postcss-value-parser";
 export const ruleName = namespace("no-non-numeric-dimensions");
 
 export const messages = utils.ruleMessages(ruleName, {
-  rejected: unit => `Expected "$value * 1${unit}" instead of "#{value}${unit}"`
+  rejected: unit =>
+    `Expected "$value * 1${unit}" instead of "#{value}${unit}". Consider writing "value" in terms of ${unit} originally.`
 });
 
 export const units = [
@@ -65,11 +66,7 @@ export const units = [
 
   // Flexible lengths:
   // https://www.w3.org/TR/css-grid-1/#fr-unit
-  "fr",
-
-  // Percentage:
-  // https://www.w3.org/TR/css-values-4/#percentages
-  "%"
+  "fr"
 ];
 
 export default function rule(primary) {