Feature/babel6 simple #81
Conversation
| @@ -12,10 +12,9 @@ function getPackagePath(packageName) { | |||
|
|
|||
| module.exports = function(env) { | |||
| var isProd = env === 'production'; | |||
| var cssLoader = 'css?modules&importLoaders=1&localIdentName=ReactStyleguidist-[name]__[local]!postcss'; | |||
| var cssLoader = 'css?module&importLoaders=1&localIdentName=ReactStyleguidist-[name]__[local]!postcss'; | |||
There was a problem hiding this comment.
My bad... #willfix
|
That’s great, thank you very much! The only thing I’d like to change is Lodash imports: I prefer |
| @@ -0,0 +1 @@ | |||
| v5 | |||
There was a problem hiding this comment.
Is it required by Babel 6 or is it a good practice or something very useful? ;-)
There was a problem hiding this comment.
Not required by Babel 6, but incredibly useful to people who need to switch between versions of Node: on some projects I need to use the Node LTS version (4.2.x) to stay in sync with an environment, on others I want to switch to v5.
Using https://github.com/wbyoung/avn, simply by cd'ing into the directory I get switched to the project-specific version. I can certainly remove, but it's a nice feature for some.
|
Re the preference for lodash import syntax, I'd suggest that it's more in line with the direction that lodash itself is going to reference the module directly? |
|
Modules, not packages. And now it’s very simple (in 3.x we had to write |
|
Removed all references to lodash.x packages and replaced |
A reduced change set rebased off master