Ensuring example re-renders always work #2148
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
mountNode
never changes in the previous version of the code,this.callbackRef
would not get called after an error was thrown. After a second re-render with new code, the Example would simply be blank on the screen (not rendering either an Example or an error message).react-styleguidist/src/client/rsg-components/Preview/Preview.tsx
Lines 131 to 136 in 0802ffb
This code ensures that we always get an Example re-render when new code is present.