DevServer configuration passed by user is not replaced #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
|
Can I have some support here? I can't understand why my change make fail this Cypress test 🙏 I run it in my local environment and the test passed correctly. |
|
FYI, looks like we've duplicated efforts here. Here's mine: |
|
@dannobytes well, to me counts it to get fixed :) Your PR is passing the tests so when it is merged let me know I will close mine :) Still very confused about why my PR make fail them 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue created here: #2029
I discovered that the base configuration was replacing the configuration passed by the WebPack configuration of the user. This PR correct the bug and add a test in order to confirm the correct functionality.