Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update react-docgen #1288

Merged
merged 2 commits into from Jun 21, 2019

Conversation

smashercosmo
Copy link
Collaborator

@smashercosmo smashercosmo commented Feb 25, 2019

@smashercosmo
Copy link
Collaborator Author

I'm not quite sure, if it's a breaking change or not) But I have a feeling that it is, because it's affects how babel config is resolved.

@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

Merging #1288 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/loaders/props-loader.js 97.82% <100%> (ø) ⬆️
babel.config.js 100% <0%> (ø)

Copy link

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The important part is setting the filename 👍If there are any issues with react-docgen feel free to ping me always.

I guess it would be breaking on your side as it adds babel config support by default. We were discussing the same within react-docgen, as it should not break anything as long as the babel config in the project is correct, but who knows how individual projects are setup. So in the end we went for a major.

@danez
Copy link

danez commented Feb 25, 2019

I also just released 4.0.1 with a fix for proptypes support (reactjs/react-docgen#330).

@smashercosmo
Copy link
Collaborator Author

Ok, I'll update

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I guess we can make a major release as well just in case.

@smashercosmo
Copy link
Collaborator Author

react-docgen updated to 4.0.1

@smashercosmo
Copy link
Collaborator Author

react-docgen updated to 4.1.0

@sapegin
Copy link
Member

sapegin commented Jun 21, 2019

We're going to merge this for now. If it breaks the whole internet, @okonet offered to fix it ;-)

@sapegin sapegin merged commit 5b9b517 into styleguidist:master Jun 21, 2019
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 9.1.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade react-docgen to 4.0.0
5 participants