New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update react-docgen #1288
Chore: update react-docgen #1288
Conversation
I'm not quite sure, if it's a breaking change or not) But I have a feeling that it is, because it's affects how babel config is resolved. |
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The important part is setting the filename 👍If there are any issues with react-docgen feel free to ping me always.
I guess it would be breaking on your side as it adds babel config support by default. We were discussing the same within react-docgen, as it should not break anything as long as the babel config in the project is correct, but who knows how individual projects are setup. So in the end we went for a major.
I also just released 4.0.1 with a fix for proptypes support (reactjs/react-docgen#330). |
Ok, I'll update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I guess we can make a major release as well just in case.
f7222d3
to
ad7668c
Compare
react-docgen updated to 4.0.1 |
ad7668c
to
2be9c0a
Compare
react-docgen updated to 4.1.0 |
We're going to merge this for now. If it breaks the whole internet, @okonet offered to fix it ;-) |
🎉 This PR is included in version 9.1.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #1279
(reference: https://babeljs.io/docs/en/options#filename)