Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for sorting union members #503

Merged
merged 4 commits into from
May 29, 2024

Conversation

pwolfert
Copy link
Contributor

@pwolfert pwolfert commented May 20, 2024

Background

I have a problem in Storybook docs where the order of union members is unpredictable. As far as I can tell, it's deterministic, but I just can't determine what it will be from build to build. A single commit of our code is consistent, but unrelated changes to our codebase can end up changing the order in which strings in a union are printed out in our prop tables. This is more than an annoyance because I have regression tests around the content of the documentation, and I can't lock onto it with a snapshot if the order keeps changing; it gives me false negatives all the time.

Summary of changes

I've added a shouldSortUnions configuration option that, when used in combination with shouldExtractValuesFromUnion will make sure the members are sorted in a consistent way (string sort order).

Fixes #302

Verification

I wrote unit tests, but I was unable to get the examples running due to some outdated dependencies. I did verify my changes in Storybook, however. See the screenshots below. In order to set the correct options for this library from the Storybook config, I had to extend the defaults like this:

import { typescript as typescriptPresets } from '@storybook/core-server/dist/presets/common-preset';

const config: StorybookConfig = {
  typescript: {
    reactDocgen: 'react-docgen-typescript',
    reactDocgenTypescriptOptions: {
      ...typescriptPresets().reactDocgenTypescriptOptions,
      shouldSortUnions: true,
    }
  },
  // ...other settings
};

export default config;

(See also storybookjs/storybook#26496 and specifically this comment.)

Before

Prop table in Storybook showing a union type with members printed in an arbitrary order

After

Prop table in Storybook showing a union type with members printed in sorted order

I'm going to actually leave the enums out of it because they get converted into numbers by default, and sorting them becomes meaningless. In the next commit, I'll change the name of everything to reflect that
@pwolfert pwolfert mentioned this pull request May 20, 2024
@pwolfert
Copy link
Contributor Author

Added details about how I verified it in Storybook, since I was having trouble verifying it in the examples.

@pwolfert pwolfert changed the title Add option for sort union members Add option for sorting union members May 22, 2024
@pvasek pvasek merged commit 09aeea3 into styleguidist:master May 29, 2024
1 check passed
@pwolfert pwolfert deleted the pwolfert/sort-unions branch May 29, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort enum types?
2 participants