Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort enum types? #302

Closed
AndrewLeedham opened this issue Sep 24, 2020 · 6 comments · Fixed by #503
Closed

Sort enum types? #302

AndrewLeedham opened this issue Sep 24, 2020 · 6 comments · Fixed by #503
Labels
stale There is no activity for a long time.

Comments

@AndrewLeedham
Copy link
Contributor

Union ordering in TypeScript changes between versions and has no guarantee. Usually this is fine, but since react-docgen-typescript is often used for visual display it seems more important. E.g. something like 1 | 2 | 3 | 4 | 5 | 6 could be outputted something like 1 | 6 | 2 | 3 | 4 | 5, which looks strange.

Does it seem feasible to parse and sort unions?
@github-actions
Copy link

github-actions bot commented Oct 9, 2021

There was no activity for a long time. Closing this issue as obsolete. In case it is still valid, please, open a new one.

@github-actions github-actions bot added the stale There is no activity for a long time. label Oct 9, 2021
@github-actions
Copy link

Closing this issue as obsolete.

@quantizor
Copy link

quantizor commented Apr 5, 2022 •
edited

@pvasek could this be reopened please? I'm getting complaints from users about union types being oddly sorted because of this same issue and would love to see it fixed.

@pvasek pvasek removed the stale There is no activity for a long time. label Apr 6, 2022
@pvasek pvasek reopened this Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

There was no activity for a long time. The issue will be closed soon.

@github-actions github-actions bot added the stale There is no activity for a long time. label Apr 6, 2023
@github-actions
Copy link

Closing this issue as obsolete.

@pwolfert pwolfert mentioned this issue May 20, 2024
Merged
@pwolfert
Copy link
Contributor

Opened a pull request for this functionality here: #503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale There is no activity for a long time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option for sorting union members pwolfert/react-docgen-typescript
4 participants
@quantizor @pvasek @AndrewLeedham @pwolfert