Add missing types AnyIfEmpty, ThemeProps, ThemedStyledProps and StyledProps

[takurinton]

refs #4062 #4117

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/styled-components/index.d.ts#L37-L43

Add more missing types in addition to #4117.

I added some of them.

• AnyIfEmpty
• ThemeProps
• ThemedStyledProps
• StyledProps

[takurinton]

As @grubersjoe has written, the absence of ThemedStyledProps can be sort of resolved with this method.
#4062 (comment)

I think it's also a strategy to write this in the migration guide.
What do @probablyup think??

[quantizor]

This could definitely be an alias to something else like ExecutionContext

[quantizor]

But it'd need to be on top of #4103 so we can have the first generic param to ExecutionContext be the Theme

[takurinton]

Should it be defined as an alias? Or should I add to the migration guide?

[takurinton]

@probablyup
#4103 is still WIP, so I felt it wouldn't be too late to merge this PR first.
Until then, how about exporting the conventional ThemeProps once?

What do you think??

[bcole808]

When I upgraded from v5 to v6, I replaced ThemeProps<T> with ExecutionContext in my codebase.

If we do decide to add this to ease upgrading that it should be aliased instead of declaring a new type. For example:

export interface ThemeProps extends ExecutionContext {}

[takurinton]

I've done the same in my codebase, but I'm afraid it won't accept generics.
I think I'll either wait for the ExecutionContext to accept generics in #4103, or temporarily include the code in its current state and include it later in #4103.

[bcole808]

When I upgraded from v5 to v6, I was able to replace ThemedStyledProps<P, T> with P & ExecutionContext in my codebase.

If we do want to add some aliases for the old v5 types to make upgrading easier, we could map them to the new types like this:

export type ThemedStyledProps<P> = P & ExecutionContext;

[takurinton]

Sure, that would be fine, but it would lead to inconsistencies in the type arguments of StyledProps.

I think it's better to wait for this to be addressed.
https://github.com/styled-components/styled-components/pull/4103/files#diff-adc775db811d749ad367a5fd61454d85f453f549d088fd97ea1575c3eb3290f4R75-R76

(and, until then, the old-style types should be defined anyway.)

[bcole808]

👍 This looks reasonable to me. Aliasing these old type names from v5 to the new equivalent types in v6 should make upgrading easier for folks.

[kaedenwile]

ThemeProps was generic in @types/styled-components package:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/styled-components/index.d.ts#L25C1-L28C1

[takurinton]

Yes, it is.

As mentioned in #4126 (comment), it needs to be placed on top of #4103. Or merge this first and then follow.
However, in some cases it should be possible to replace it by using ExecutionContext.

[Amerr]

Any blocks in this merging PR or is it still in review

[mthorne-godaddy]

Any update on this?