Use regex for topLevelImportPaths option #3654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is a good idea. I'd rather apply the anchors in the plugin than run around adding them to callers of the plugin. If that PR gets merged, resulting in plugin 3.0, then the dep here could change to If for some reason we go with this approach instead, then beware the anchors are backwards so it will never match. I don't know if this is somehow passing tests, but if so, it needs a new test. |
|
I'm closing this for now, I'm not sure how this macro is working at all, and I've run out of time to debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 2.x.x version of babel-plugin-styled-components, topLevelImportPath requires a regex, so we escape the literal here.