Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check dynamic creation in React 18 #3521

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Jun 29, 2021

Closes #3394
Closes #3409

@eps1lon eps1lon marked this pull request as ready for review June 29, 2021 09:03
Copy link
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@quantizor quantizor merged commit 2bfc5aa into styled-components:main Jul 1, 2021
@eps1lon eps1lon deleted the fix/react18-warn branch July 1, 2021 19:46
@nmoinvaz
Copy link

nmoinvaz commented Jul 7, 2021

Since this also affects React 17, is it possible to get a new version of styled-components released? Thanks in advance.

@lynndylanhurley
Copy link

lynndylanhurley commented Aug 21, 2021

@eps1lon @probablyup any possibility of getting a release for this?

@lynndylanhurley
Copy link

lynndylanhurley commented Aug 21, 2021

I realized this will be difficult to create a release for because of the typescript conversion. I just applied this fix to the legacy-v5 branch: #3564. Hoping it will be easier to create a v5.3.1 release with that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants