[v5] feat: pass elementToBeCreated to shouldForwardProp #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal decision whether to forward a prop is based on the combination of the key and elementToBeCreated, but only the former was passed to shouldForwardProp. This is a port of styled-components#3436 to legacy-v5
quantizor
approved these changes
Apr 6, 2021
|
Thank you @probablyup!! Really appreciate your efforts reviewing and merging pull requests. |
|
@probablyup I hate to ask for this—I'm sure you'll do it eventually without my asking—but would you mind spinning out 5.2.4 with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #3436 to legacy-v5