Fix ReferenceError: window is undefined Server-Side-Rendering

[tillhainbach]

fix #3444 by wrapping with typeof window !== 'undefined'

Issues was introduced by v5.2.2

Edit:
Patch for 15b0796

Changed target branch to legacy-v5 (I hope that's the correct one..)

[RomanHotsiy]

Pinging @probablyup directly, just in case he may be unsubscribed from other notifications in this repo.

@probablyup, sorry for bothering 🙇.
It looks like a straightforward and safe fix and there are many people impacted so decided to ping you. Thanks for your hard work on this project!

[quantizor]

This is released in 5.2.3

[davidnegley]

is the same fix also needed here https://github.com/styled-components/styled-components/blob/legacy-v5/packages/styled-components/src/base.js#L41 to fix #3374 ?

[tillhainbach]

is the same fix also needed here https://github.com/styled-components/styled-components/blob/legacy-v5/packages/styled-components/src/base.js#L41 to fix #3374 ?

I don't thing so. That if guards against a __SERVER__ flag. Looks like the __SERVER__ global is no set correctly

[nuwan-dammika]

Hi @tillhainbach

I have inherited a project that build same react code base and used to do SSR and client side rendering .

It uses Parcel build which use styled-components.browser.esm.js (for final js build) because it is building for browser. And on SSR following line error out

https://github.com/styled-components/styled-components/blob/legacy-v5/packages/styled-components/src/base.js#L41
with
window is not defined

I tried Parcel build with --target node , which fixes above issue (linked) but brings whole other errors (not related to styled-components). So have to make this work.

Currently fixed to 5.1.1, because that's the last version with window is safely handled. So do you have any suggestion to inject __SEVER__ though react code or that line get fixed.

Thanks

[nuwan-dammika]

is the same fix also needed here https://github.com/styled-components/styled-components/blob/legacy-v5/packages/styled-components/src/base.js#L41 to fix #3374 ?

I have the same issue, in my case same code base is used for SSR and Client Rendering .