Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix ToC in docs" #61

Closed
wants to merge 1 commit into from
Closed

Revert "Fix ToC in docs" #61

wants to merge 1 commit into from

Conversation

bhough
Copy link
Contributor

@bhough bhough commented Dec 16, 2016

Reverts #59

@mxstbr
Copy link
Member

mxstbr commented Dec 16, 2016

No leave it, I'll fix it. One sec!

@mxstbr mxstbr closed this Dec 16, 2016
@mxstbr mxstbr deleted the revert-59-fix-toc branch December 16, 2016 19:55
@mxstbr
Copy link
Member

mxstbr commented Dec 16, 2016

They look alright to me? Moved them to /docs... https://polished.js.org/docs/

@bhough
Copy link
Contributor Author

bhough commented Dec 16, 2016

Locally they are completely broken now and I see a docs folder with another docs folder inside of it in master, both with index.html files. Is this expected?

@mxstbr
Copy link
Member

mxstbr commented Dec 16, 2016

Yes, since polished.js.org (the homepage) will have a, well, homepage. That's why I moved the docs to /docs 😊

Go to polished.js.org, nothing there (since there is not homepage yet, going to work on that), go to https://polished.js.org/docs, there's docs! 🎉

@bhough
Copy link
Contributor Author

bhough commented Dec 16, 2016

Ok, would be nice if we can link up the assets so the docs work locally. Right now they don't get styling or the js because the relative paths don't resolve. I

@mxstbr
Copy link
Member

mxstbr commented Dec 16, 2016

I use pushstate-server locally like this: $ pushstate-server docs, and it works for me. What do you use that it doesn't work?

@bhough
Copy link
Contributor Author

bhough commented Dec 16, 2016

I was just loading up index.html in the browser directly, i can move to using pushstate-server.

@mxstbr
Copy link
Member

mxstbr commented Dec 16, 2016

Ooh, yeah that'll break since I had to resort to absolute links to the assets to make them work for the docs/ suffix 😕 Maybe we should add an npm script for that?

@bhough
Copy link
Contributor Author

bhough commented Dec 16, 2016

I'll look into adding it as part of #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants