fix(between): added error case when to/from unit is differs from mix/max #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies and fix new flow error in triangle.test.js
Fully deprecate returnUnit functionality and refactor return.
Make strict mode default when passing custom colors.
Enable bugfix:true in build and target explicit browser list
Default is now to look for a local font of the same family-name before downloading. Can be turned off by passing null to localFonts. BREAKING CHANGE: localFont will now be populated by default and may have unexpected behavior.
important helper for targeting specific rules in module returns for adding `!important`-level specificity.
triangle now returns properties in a way that allows inherit to work by declaring an individual side for the triangle color.
Allow the user to pass a default value to cssVar for when a variable is not found.
…n/max Added an error case when the unit for to/fromSize is different than min/maxScreen. This was causing bad calculations based on the differing scales. BREAKING CHANGE: If you were using a mix of unit and unitless measure or working with different units with similar scales (em/rem) you will now get an error where you may have been getting a seemingly valid calculation. fix #445
Codecov Report
@@ Coverage Diff @@
## version-4-0-release #511 +/- ##
====================================================
Coverage 99.88% 99.88%
====================================================
Files 84 84
Lines 840 843 +3
Branches 320 321 +1
====================================================
+ Hits 839 842 +3
Misses 1 1
Continue to review full report at Codecov.
|
bhough
force-pushed
the
version-4-0-release
branch
from
cda8e3b
to
6cd29ac
Compare
bhough
changed the title
bhough
added a commit
that referenced
this pull request
Jun 12, 2020
…max (#511) * chore(library): update dependencies Update dependencies and fix new flow error in triangle.test.js * refactor(stripunit): fully deprecate returnUnit Fully deprecate returnUnit functionality and refactor return. * refactor(readablecolor): make strict mode default Make strict mode default when passing custom colors. * build(babel): enable bugfix: true Enable bugfix:true in build and target explicit browser list * build(lint-staged): remove superfulous git add * build(lerna): lerna init * feat(normalize): upgrade to normalize 8.0.1 * build(docs): removed documentation.js auto generation * feat(fontface): now defaults to looking for local font first Default is now to look for a local font of the same family-name before downloading. Can be turned off by passing null to localFonts. BREAKING CHANGE: localFont will now be populated by default and may have unexpected behavior. * feat(important): important helper for module rule specificity important helper for targeting specific rules in module returns for adding `!important`-level specificity. * chore(important): update to not mutate original parameter * chore(important): add to index.js * fix(triangle): triangle now properly supports inherit triangle now returns properties in a way that allows inherit to work by declaring an individual side for the triangle color. * feat(cssvar): allow a default value for cssVar Allow the user to pass a default value to cssVar for when a variable is not found. * fix(between): added error case when to/from unit is different than min/max Added an error case when the unit for to/fromSize is different than min/maxScreen. This was causing bad calculations based on the differing scales. BREAKING CHANGE: If you were using a mix of unit and unitless measure or working with different units with similar scales (em/rem) you will now get an error where you may have been getting a seemingly valid calculation. fix #445
bhough
added a commit
that referenced
this pull request
Sep 16, 2020
…max (#511) * chore(library): update dependencies Update dependencies and fix new flow error in triangle.test.js * refactor(stripunit): fully deprecate returnUnit Fully deprecate returnUnit functionality and refactor return. * refactor(readablecolor): make strict mode default Make strict mode default when passing custom colors. * build(babel): enable bugfix: true Enable bugfix:true in build and target explicit browser list * build(lint-staged): remove superfulous git add * build(lerna): lerna init * feat(normalize): upgrade to normalize 8.0.1 * build(docs): removed documentation.js auto generation * feat(fontface): now defaults to looking for local font first Default is now to look for a local font of the same family-name before downloading. Can be turned off by passing null to localFonts. BREAKING CHANGE: localFont will now be populated by default and may have unexpected behavior. * feat(important): important helper for module rule specificity important helper for targeting specific rules in module returns for adding `!important`-level specificity. * chore(important): update to not mutate original parameter * chore(important): add to index.js * fix(triangle): triangle now properly supports inherit triangle now returns properties in a way that allows inherit to work by declaring an individual side for the triangle color. * feat(cssvar): allow a default value for cssVar Allow the user to pass a default value to cssVar for when a variable is not found. * fix(between): added error case when to/from unit is different than min/max Added an error case when the unit for to/fromSize is different than min/maxScreen. This was causing bad calculations based on the differing scales. BREAKING CHANGE: If you were using a mix of unit and unitless measure or working with different units with similar scales (em/rem) you will now get an error where you may have been getting a seemingly valid calculation. fix #445
bhough
added a commit
that referenced
this pull request
Oct 4, 2020
* chore(library): update dependencies Update dependencies and fix new flow error in triangle.test.js * refactor(stripunit): fully deprecate returnUnit Fully deprecate returnUnit functionality and refactor return. * refactor(readablecolor): make strict mode default Make strict mode default when passing custom colors. * build(babel): enable bugfix: true Enable bugfix:true in build and target explicit browser list * build(lint-staged): remove superfulous git add * build(lerna): lerna init * build(docs): removed documentation.js auto generation * feat(fontface): now defaults to looking for local font first Default is now to look for a local font of the same family-name before downloading. Can be turned off by passing null to localFonts. BREAKING CHANGE: localFont will now be populated by default and may have unexpected behavior. * feat(important): important helper for module rule specificity important helper for targeting specific rules in module returns for adding `!important`-level specificity. * chore(important): update to not mutate original parameter * chore(important): add to index.js * fix(triangle): triangle now properly supports inherit triangle now returns properties in a way that allows inherit to work by declaring an individual side for the triangle color. * feat(cssvar): allow a default value for cssVar Allow the user to pass a default value to cssVar for when a variable is not found. * fix(between): added error case when to/from unit is differs from mix/max (#511) * chore(library): update dependencies Update dependencies and fix new flow error in triangle.test.js * refactor(stripunit): fully deprecate returnUnit Fully deprecate returnUnit functionality and refactor return. * refactor(readablecolor): make strict mode default Make strict mode default when passing custom colors. * build(babel): enable bugfix: true Enable bugfix:true in build and target explicit browser list * build(lint-staged): remove superfulous git add * build(lerna): lerna init * feat(normalize): upgrade to normalize 8.0.1 * build(docs): removed documentation.js auto generation * feat(fontface): now defaults to looking for local font first Default is now to look for a local font of the same family-name before downloading. Can be turned off by passing null to localFonts. BREAKING CHANGE: localFont will now be populated by default and may have unexpected behavior. * feat(important): important helper for module rule specificity important helper for targeting specific rules in module returns for adding `!important`-level specificity. * chore(important): update to not mutate original parameter * chore(important): add to index.js * fix(triangle): triangle now properly supports inherit triangle now returns properties in a way that allows inherit to work by declaring an individual side for the triangle color. * feat(cssvar): allow a default value for cssVar Allow the user to pass a default value to cssVar for when a variable is not found. * fix(between): added error case when to/from unit is different than min/max Added an error case when the unit for to/fromSize is different than min/maxScreen. This was causing bad calculations based on the differing scales. BREAKING CHANGE: If you were using a mix of unit and unitless measure or working with different units with similar scales (em/rem) you will now get an error where you may have been getting a seemingly valid calculation. fix #445 * feat(ellipsis): ellipsis now optionally supports multline truncation * feat(easings): separate timingFunctions into separate easing functions (#513) re #402 * chore(package.json): clean up and update deps * Replace snapshots with specific expect statements * chore(rebase): rebase on main * docs(docs): return docs to build for V4 * fix(docs): properly set directory for pushstate-server * build(workflows): update github workflows to only run on unbuntu and use latest versions * fix(lineargradient): fix issues with rgba as first value with spaces * feat(math): move non-standard formulas to exponentials presets * build(package.json): prettier config and updated babel rollup plugin * docs(docs): updates documentation index * docs(easings): add easings to docs * style(js): run new prettier config across all JS * chore(package.json): add beta tag * docs(timingfunctions): comment on timingFunctions deprecation * chore(library): rebuild package * chore(docs): add pushstate-server to docs * fix(index.js): add easings to index.js for docs site build * build(package.json): bump version for release Co-authored-by: Vincent Ricard <magic@magicninja.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an error case when the unit for to/fromSize is different than min/maxScreen. This was causing
bad calculations based on the differing scales.
BREAKING CHANGE: If you were using a mix of unit and unitless measure or working with different
units with similar scales (em/rem) you will now get an error where you may have been getting a
seemingly valid calculation.
fix #445