fix(triangle): Triangles can inherit their color #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhough
requested changes
May 11, 2019
| @@ -83,7 +91,8 @@ Object { | |||
|
|
|||
| exports[`triangle should properly render bottomRight pointing arrow with blue foregroundColor, width of 20px and height 20px 1`] = ` | |||
| Object { | |||
| "borderColor": "transparent transparent blue transparent", | |||
| "borderBottomColor": "blue", | |||
| "borderColor": "transparent", | |||
There was a problem hiding this comment.
Unfortunately, key order matters a lot for this particular use case. borderColor will override borderBottomColor and make the element transparent. We had to do some magic in the original implementation to account for this: https://github.com/styled-components/polished/blob/8607d641e27d945612e81a3078b1674200d6286e/src/mixins/triangle.js
There was a problem hiding this comment.
Is the object always sorted by key or is it just an artifact of the testing framework?
Did you mean using the border color helper or adding !important to borderBottomColor?
| @@ -113,7 +124,8 @@ Object { | |||
|
|
|||
| exports[`triangle should properly render top pointing arrow with green foregroundColor, width of 20px and height 20px 1`] = ` | |||
| Object { | |||
| "borderColor": "transparent transparent green transparent", | |||
| "borderBottomColor": "green", | |||
| "borderColor": "transparent", | |||
There was a problem hiding this comment.
Same concern as above here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #430