Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump @babel/runtime from 7.9.2 to 7.12.0 #547

Merged
merged 2 commits into from Oct 15, 2020

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Oct 15, 2020

@babel/runtime 7.9.0 is not compatible with webpack v5, so we cannot bundle polished with webpack v5 due to the following error.

    error: Error: Can't resolve './construct' in '/repos/github.com/kufu/smarthr-ui/node_modules/polished/node_modules/@babel/runtime/helpers/esm'
    Did you mean 'construct.js'?
    BREAKING CHANGE: The request './construct' failed to resolve only because it was resolved as fully specified
    (probably because the origin is a '*.mjs' file or a '*.js' file where the package.json contains '"type": "module"').
    The extension in the request is mandatory for it to be fully specified.
    Add the extension to the request.

This is fixed at babel/babel#12058 (comment) and released as 7.12.0, so I've updated @babel/runtime to the version.

i18next/i18next#1513 is the same case.

@koba04 koba04 requested a review from bhough as a code owner October 15, 2020 13:57
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #547 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #547   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           88        88           
  Lines          831       831           
  Branches       305       305           
=========================================
  Hits           831       831           
Flag Coverage Δ
#unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcc97c...a98c362. Read the comment docs.

Copy link
Contributor

@bhough bhough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @koba04. We will get this merged and released today.

@bhough bhough merged commit 200f841 into styled-components:main Oct 15, 2020
@koba04 koba04 deleted the bump-babel-runtime-7.12.0 branch October 16, 2020 00:59
@koba04
Copy link
Contributor Author

koba04 commented Oct 16, 2020

@bhough Thank you for getting merged and released this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants