Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support webpack v5 #1057

Merged
merged 3 commits into from Oct 21, 2020
Merged

fix: support webpack v5 #1057

merged 3 commits into from Oct 21, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 11, 2020

This PR contains the following updates:

Package Type Update Change
webpack devDependencies major ^4.44.2 -> ^5.0.0

Release Notes

webpack/webpack

v5.0.0

Compare Source

Announcement and changelog


Renovate configuration

馃搮 Schedule: "before 10am on Monday" in timezone Asia/Tokyo.

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner October 11, 2020 15:28
@renovate renovate bot requested review from nabeliwo and MRTAFU and removed request for a team October 11, 2020 15:28
@renovate renovate bot added the renovate label Oct 11, 2020
@reg-suit
Copy link

reg-suit bot commented Oct 11, 2020

鉁ㄢ湪 That's perfect, there is no visual difference! 鉁ㄢ湪

Check out the report here.

@netlify
Copy link

netlify bot commented Oct 11, 2020

Deploy preview for smarthr-ui ready!

Built with commit cd1725e

https://deploy-preview-1057--smarthr-ui.netlify.app

@koba04
Copy link
Contributor

koba04 commented Oct 15, 2020

I'll take on this.

@koba04 koba04 self-assigned this Oct 15, 2020
@koba04
Copy link
Contributor

koba04 commented Oct 15, 2020

I've fixed ecma-version-validator-webpack-plugin to support webpack v5 and have released it as v.1.10.

@koba04
Copy link
Contributor

koba04 commented Oct 15, 2020

polished, which is a dependency of styled-components, has an issue when it bundles with webpack v5, so I've sent a PR to fix it.
styled-components/polished#547

@koba04 koba04 changed the title chore(deps): update dependency webpack to v5 fix: support webpack v5 Oct 16, 2020
nabeliwo
nabeliwo previously approved these changes Oct 20, 2020
@nabeliwo
Copy link
Member

@koba04 Thank you for great contribution 馃帀
I'm sorry, please resolve conflicts 馃檹

@koba04
Copy link
Contributor

koba04 commented Oct 20, 2020

@nabeliwo Done 馃憤

@nabeliwo nabeliwo merged commit 3d8d14e into master Oct 21, 2020
@nabeliwo nabeliwo deleted the renovate/webpack-5.x branch October 21, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants