Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toHaveStyleRule support classes with displayName prefix #302

Merged
merged 3 commits into from Apr 9, 2020
Merged

Fix toHaveStyleRule support classes with displayName prefix #302

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
980b7f6
Fix support classes with displayName prefix
Feb 6, 2020
002ccc5
simplify regexp on get classname
Apr 8, 2020
e4a3ed3
add unit test for custom prefix/display name
Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/toHaveStyleRule.js
View file
Open in desktop
Expand Up @@ -68,7 +68,7 @@ const getModifiedClassName = (className, staticClassName, modifier = "") => {
};

const hasClassNames = (classNames, selectors, options) => {
const staticClassNames = classNames.filter(x => x.startsWith("sc-"));
const staticClassNames = classNames.filter(x => /^(\w+-)?sc-\w+/.test(x));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want the \w+ part at the end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @vxcamiloxv

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 002ccc5 cc @probablyup


return classNames.some(className =>
staticClassNames.some(staticClassName =>
Expand Down