Update Matchers interface #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blainekasten
approved these changes
Oct 29, 2019
|
@blainekasten as far as i can tell, for custom matchers passed to based on these lines: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jest/index.d.ts#L838 |
|
bump @probablyup can we get this through the door? |
quantizor
approved these changes
Nov 12, 2019
|
@tobilen does this need to be done for master as well? |
|
most likely. see #269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
Matcherstype of definitelytyped's jest package have been updated (see https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jest/index.d.ts#L639 ), which causes a compilation error since the interfaces don't match anymore.See: enzymejs/enzyme-matchers#318 or testing-library/jest-dom#152
This PR changes the type to match the new one.