Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use closures with preserved names as option handler functions #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use closures with preserved names as option handler functions #171

wants to merge 1 commit into from

Conversation

manpenaloza
Copy link
Member

this pr aims to simplify this file in terms of:

  • no need to actively declare new functions state gets passed to
  • no need to pass through state down the runtime chain

@manpenaloza
use closures with preserved names as option handler functions
73592ac 
this pr aims to simplify this file in terms of:
- no need to actively declare new functions `state` gets passed to
- no need to pass through `state` down the runtime chain
@manpenaloza
Copy link
Member Author

pr references issue #170

quantizor
quantizor approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@quantizor
Copy link
Collaborator

Needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantizor quantizor quantizor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manpenaloza @quantizor