This repository has been archived by the owner on Feb 4, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seb33300
reviewed
May 7, 2019
# Conflicts: # Tests/DatatableTest.php # Tests/Datatables/PostDatatable.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I joined this library as a maintainer a while ago and I struggle to handle the Pull Requests because I my knowledge of all internals of this library is a bit limited. Therefor some extra unit tests are very helpful, to prevent regression.
This is a first step to improve tests for this library. In the feature, I'd like to see updated unit tests as a requirement to every PR.
What I've done so far:
PostDatatable