Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Updated unit tests #885

Merged
merged 16 commits into from Aug 28, 2019
Merged

Conversation

stephanvierkant
Copy link
Collaborator

@stephanvierkant stephanvierkant commented May 7, 2019

I joined this library as a maintainer a while ago and I struggle to handle the Pull Requests because I my knowledge of all internals of this library is a bit limited. Therefor some extra unit tests are very helpful, to prevent regression.

This is a first step to improve tests for this library. In the feature, I'd like to see updated unit tests as a requirement to every PR.

What I've done so far:

  • Upgraded Symfony requirement to supported versions: 3.4 (LTS) or ^4.1. Other versions don't get security updates to it's important to upgrade as soon as possible.
  • Fixed some PHPUnit deprecations
  • Added some columns to PostDatatable
  • Added PHP 7.2 and 7.3 to Travis, remove PHP 7.1. since we don't support that version anymore.
  • Used Flex to install specific Symfony version (Used Symfony Flex in favor of symfony/lts symfony/swiftmailer-bundle#293)

@stephanvierkant stephanvierkant changed the title Updated unit tests [WIP] Updated unit tests May 7, 2019
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@stephanvierkant stephanvierkant changed the title [WIP] Updated unit tests Updated unit tests Aug 28, 2019
@stephanvierkant stephanvierkant merged commit 4096b36 into stwe:master Aug 28, 2019
@stephanvierkant stephanvierkant deleted the updatedtests branch August 28, 2019 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants