Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump log4js from 6.2.1 to 6.3.0 #2668

Closed
wants to merge 2 commits into from

Conversation

bartekleon
Copy link
Member

closes: #2346

@nicojs
Copy link
Member

nicojs commented Dec 23, 2020

@kmdrGroch please don't forget about log4js-node/log4js-node#1037

This was the reason for me not to migrate earlier. If I recall correctly, the Linux pipelines will fail.

@bartekleon
Copy link
Member Author

@kmdrGroch please don't forget about log4js-node/log4js-node#1037

This was the reason for me not to migrate earlier. If I recall correctly, the Linux pipelines will fail.

that is indeed strange :/ I didn't know there was such an issue out there

@nicojs
Copy link
Member

nicojs commented Jan 13, 2021

Yeah, we'll need to investigate. We're probably doing something undocumented that isn't supported anymore. For example, we're calling log4js.configure multiple times, that's probably shady territory.

The log4js configuration was complicated because of the old ConfigEditor plugins. They had the ability to change the logLevel. This is why we choose to call log4js.configure a second time after loading them. Since those plugins are no longer supported (I love v4 🎉), we might be able to simplify the log4js configuration.

@bartekleon bartekleon closed this Aug 6, 2021
@lamweili
Copy link

@nicojs You will be able to call log4js.configure() multiple times from log4js@6.4.0 onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants