Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

[StructurizrPlantUMLExporter] plantuml.sequenceDiagrams changes the export of static diagrams #24

Closed
dgutson opened this issue Oct 26, 2022 · 2 comments

Comments

@dgutson
Copy link

dgutson commented Oct 26, 2022

The generation of the static views are impacted depending on plantuml.sequenceDiagrams true.

Given

workspace "Test Product Architecture" "Model of the Test Platform." {

    !identifiers hierarchical

    model {
        group Customer {
            ees_user = person "EES users" "" "users"
            ends_user = person "ENDS user"
            frontend_user = person "FE user"
            webhooks_user = person "Webhooks User" "" "robot_user"
            EAS = softwaresystem "EAS" "Service1" {
                SP = container "Processor" "Something" "Node.js"
                engine = container "Engine" "Processes the data" "Go"

                SP -> engine "Sends data"
                engine -> SP "Send results"
            }

            backend = softwaresystem "Backend" "Backend1" "multi" {
                database = container "DB" "" "MongoDB" "DB"
                app = container "App" "Backend Server" "Node.js" {
                    s1 = component "Service1"
                    s2 = component "Service2"
                    s1 -> s2
                }

                app -> database "Uses"
            }

            backend.app -> EAS.SP "Send data"
            EAS.SP -> backend.app "Send results"
        }
    }

    views {
        properties {
            "plantuml.includes" "extra_styles.puml"
            #"c4plantuml.tags" "true"
            "plantuml.legend" "false"
            plantuml.sequenceDiagrams true
        }

        systemlandscape TheSystemLandscape {
            include *
            autoLayout
        }

        component backend.app {
            include *
            autoLayout
        }

        theme default

        styles {
            element "DB" {
                shape Cylinder
            }

            element "dataset" {
                background #006400
            }

            element "robot_user" {
                properties {
                    c4plantuml.sprite robot
                }
            }

            element "users" {
                properties {
                    c4plantuml.sprite users
                }
            }

            element "multi" {
                properties {
                    c4plantuml.shadow true
                }    
            }
        }
    }
}

These diagrams are generated:
image
image

However, when plantuml.sequenceDiagrams true is not in the properties block, the same diagrams are generated as following:
image
image

I think that the first pair is broken since the enclosing scopes (group, container) are not drawn.

@simonbrowndotje
Copy link
Contributor

Adding a simpler reproducer, and a note that this only affects the StructurizrPlantUMLExporter:

workspace {

    model {
        group "Name" {
            softwareSystem = softwareSystem "Software System"
        }
    }

    views {
        properties {
            "plantuml.sequenceDiagrams" "true"
        }
        systemLandscape {
            include *
            autolayout
        }
    }
    
}

@simonbrowndotje simonbrowndotje changed the title [BUG] plantuml.sequenceDiagrams changes the export of static diagrams [StructurizrPlantUMLExporter] plantuml.sequenceDiagrams changes the export of static diagrams Oct 27, 2022
@dgutson
Copy link
Author

dgutson commented Oct 27, 2022

docker image pls :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants