Fixes #24.

structurizr · Oct 27, 2022 · 438eb31 · 438eb31
1 parent 060e5e2
commit 438eb31
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 1 deletion.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -3,6 +3,7 @@
 ## 1.8.0 (unreleased to Maven Central)
 
 - The C4-PlantUML export now mimics how the Structurizr renderer uses tags when a view set property named `c4plantuml.tags` is set to `true`.
+- Fixes #24 (plantuml.sequenceDiagrams changes the export of static diagrams).
 
 ## 1.7.0 (3rd October 2022)
 

diff --git a/src/main/java/com/structurizr/export/plantuml/AbstractPlantUMLExporter.java b/src/main/java/com/structurizr/export/plantuml/AbstractPlantUMLExporter.java
@@ -166,7 +166,7 @@ protected boolean includeTitle(View view) {
     }
 
     protected boolean useSequenceDiagrams(View view) {
-        return "true".equalsIgnoreCase(view.getViewSet().getConfiguration().getProperties().getOrDefault(PLANTUML_SEQUENCE_DIAGRAMS_PROPERTY, "false"));
+        return view instanceof DynamicView && "true".equalsIgnoreCase(view.getViewSet().getConfiguration().getProperties().getOrDefault(PLANTUML_SEQUENCE_DIAGRAMS_PROPERTY, "false"));
     }
 
     @Override

diff --git a/src/test/java/com/structurizr/export/plantuml/StructurizrPlantUMLDiagramExporterTests.java b/src/test/java/com/structurizr/export/plantuml/StructurizrPlantUMLDiagramExporterTests.java
@@ -922,4 +922,55 @@ public void testLegend() {
                 "@enduml", diagram.getLegend().getDefinition());
     }
 
+    @Test
+    public void staticDiagramsAreUnchangedWhenSequenceDiagramsAreEnabled() {
+        Workspace workspace = new Workspace("Name", "Description");
+        Model model = workspace.getModel();
+
+        model.addSoftwareSystem("Software System").setGroup("Group");
+        SystemLandscapeView view = workspace.getViews().createSystemLandscapeView("key", "Description");
+        view.addAllElements();
+
+        StructurizrPlantUMLExporter exporter = new StructurizrPlantUMLExporter();
+        Diagram diagram;
+        String expected = "@startuml\n" +
+                "title System Landscape\n" +
+                "\n" +
+                "top to bottom direction\n" +
+                "\n" +
+                "skinparam {\n" +
+                "  shadowing false\n" +
+                "  arrowFontSize 10\n" +
+                "  defaultTextAlignment center\n" +
+                "  wrapWidth 200\n" +
+                "  maxMessageSize 100\n" +
+                "}\n" +
+                "\n" +
+                "hide stereotype\n" +
+                "\n" +
+                "skinparam rectangle<<SoftwareSystem>> {\n" +
+                "  BackgroundColor #dddddd\n" +
+                "  FontColor #000000\n" +
+                "  BorderColor #9a9a9a\n" +
+                "}\n" +
+                "\n" +
+                "package \"Group\\n[Group]\" <<group>> {\n" +
+                "  skinparam PackageBorderColor<<group>> #cccccc\n" +
+                "  skinparam PackageFontColor<<group>> #cccccc\n" +
+                "\n" +
+                "  rectangle \"==Software System\\n<size:10>[Software System]</size>\" <<SoftwareSystem>> as SoftwareSystem\n" +
+                "}\n" +
+                "\n" +
+                "\n" +
+                "@enduml";
+
+        diagram = exporter.export(view);
+        assertEquals(expected, diagram.getDefinition());
+
+        workspace.getViews().getConfiguration().addProperty(StructurizrPlantUMLExporter.PLANTUML_SEQUENCE_DIAGRAMS_PROPERTY, "true");
+
+        diagram = exporter.export(view);
+        assertEquals(expected, diagram.getDefinition());
+    }
+
 }