fix: coerce property value defined as array of ObjectID #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnes512
requested review from
dhmlau,
emonddr,
hacksparrow and
jannyHou
as code owners
agnes512
changed the title
jannyHou
reviewed
Jun 30, 2020
| title: 'arrayOfObjectID', | ||
| }); | ||
| const found = await Article.findOne({where: {title: 'arrayOfObjectID'}}); | ||
| found.xidArr.should.be.an.Array().which.containDeep([new ds.ObjectID(objectIDLikeString)]); | ||
| // the type of the returned array is actually string even it's stored as ObjectIds in the db as expected |
There was a problem hiding this comment.
the type of the returned array is actually string
@agnes512 Isn't the returned xidArr in type objectId? From the test case, it's not string...
There was a problem hiding this comment.
I am confused too. I checked with found.xidArr[0].should.be.an.instanceOf(ds.ObjectID), and it fails, while the xid test case in L129 is an objectId. I couldn't find where the array ges converted though.
There was a problem hiding this comment.
Do you know what's the typeof found.xidArr[0] ?
|
@slnode test please |
jannyHou
approved these changes
Jul 10, 2020
| ]); | ||
| // check if the array is stored in ObjectId | ||
| const raw = await findRawModelDataAsync('ArticleC', found[0].id); | ||
| raw.xidArr[0].should.be.an.instanceOf(ds.ObjectID); |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes loopbackio/loopback-next#5848 : failed to set array of strings to ObjectId with
dataType: objectid.Checklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machine