Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce values of array property defined as ObjectID type #619

Merged
merged 1 commit into from Mar 11, 2021

Conversation

mrbatista
Copy link
Contributor

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

Signed-off-by: = <mrbatista@users.noreply.github.com>
Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mrbatista . IIUC, the PR is allowing to have arrays of objectId in where clause? which is different from #582?

@mrbatista
Copy link
Contributor Author

mrbatista commented Mar 9, 2021

Thank you @mrbatista . IIUC, the PR is allowing to have arrays of objectId in where clause? which is different from #582?

@agnes512 correct! The coercePropertyValue method is used to coerce data model only.
The value of an array of ObjectId is not coerced in where clause.

Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚢

@agnes512 agnes512 merged commit e046705 into loopbackio:master Mar 11, 2021
@mrbatista
Copy link
Contributor Author

@agnes512 When release a new version that include this change?

@dhmlau
Copy link
Member

dhmlau commented Mar 12, 2021

@mrbatista, I can publish a release early next week. (trying to avoid doing it on a Friday afternoon!)

@mrbatista
Copy link
Contributor Author

@dhmlau Please release a new version.
Thanks.

@dhmlau
Copy link
Member

dhmlau commented Mar 22, 2021

@mrbatista, loopback-connector-mongodb@6.0.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants