Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: buf bsr #512

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: buf bsr #512

wants to merge 3 commits into from

Conversation

moritzzimmer
Copy link
Member

@moritzzimmer moritzzimmer commented Jul 7, 2023

what

PoC to test buf's maven remote packages (see https://buf.build/docs/bsr/remote-packages/maven/).

see https://buf.build/stroeer/tapir/assets/main for assets

learnings

✅ buf's remote packages are separated for proto and grpc per default
✅ packages build for various proto and grpc versions are available
✅ we could remove the java package release process in tapir and simplify our tools
✅ registries for node and go are available as well (not tested in this poc)
✅ automatic documentation is nice and we could simplify our docs toolchain, see https://buf.build/stroeer/tapir/docs/main

🟡 we can't specifiy custom tag values for default buf push GitHub action (we could create a custom make target though)
🟡 free plan is up to 100 types (according to buf beta price we currently have 63)

❌ packages names are different (see large diff in https://github.com/stroeer/paperboy/pull/1984) and can't be changed easily atm, see bufbuild/plugins#636

outcome

I would push to the BSR to use the documentation but stick to remote plugins for code generation for now)

@moritzzimmer moritzzimmer changed the title feat/buf bsr feat: buf bsr Jul 7, 2023
@moritzzimmer moritzzimmer self-assigned this Jul 7, 2023
@moritzzimmer moritzzimmer added 📖 documentation Improvements or additions to documentation 💅 enhancement New feature or request github_actions Pull requests that update Github_actions code labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation 💅 enhancement New feature or request github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant