Issue checkstyle#12345: fix NoWhitespaceAfterCheck false positive

strkkk · Nov 5, 2022 · e708e25 · e708e25
1 parent b1c4475
commit e708e25
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoWhitespaceAfterCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoWhitespaceAfterCheck.java
@@ -570,8 +570,11 @@ private static DetailAST getIdentLastToken(DetailAST ast) {
      * @return dot preceding the left bracket
      */
     private static DetailAST getPrecedingDot(DetailAST leftBracket) {
-        final DetailAST referencedClassDot =
-                leftBracket.getParent().findFirstToken(TokenTypes.DOT);
+        final DetailAST parent = leftBracket.getParent();
+        DetailAST referencedClassDot = null;
+        if (parent.getType() != TokenTypes.ASSIGN) {
+            referencedClassDot = parent.findFirstToken(TokenTypes.DOT);
+        }
         final DetailAST referencedMemberDot = leftBracket.findFirstToken(TokenTypes.DOT);
         return Optional.ofNullable(referencedMemberDot).orElse(referencedClassDot);
 

diff --git a/...ols/checkstyle/checks/whitespace/nowhitespaceafter/InputNoWhitespaceAfterTestDefault.java b/...ols/checkstyle/checks/whitespace/nowhitespaceafter/InputNoWhitespaceAfterTestDefault.java
@@ -307,4 +307,12 @@ Object foo() {
 
     int someStuff8
     []; // violation
+
+    Object o;
+
+    void some() {
+        Object oo = new Object[4];
+        this.o = ((Object[]) oo)[1];
+        this.o = ((java.lang.Object[]) oo)[1];
+    }
 }