Rename Stripe.configuration to Stripe.config
#972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a cosmetic change that renames `Stripe.configuration` to just `Stripe.config`. We use the shorter "config" in most other places including `StripeClient#config`, so I feel that this is overall more consistent. This change is backwards compatible because the new accessor came in with #968, and that hasn't been given a formal release yet. I've left the class name as `StripeConfiguration` which IMO is fine. The class uses the expanded form of the name while vars and accessors use the shorter `config`. Also, `StripeConfiguration` has been around a little bit longer, so renaming it is somewhat backwards incompatible too.
brandur-stripe
changed the title
Stripe.configuration to Stripe.config
|
Ugh, |
richardm-stripe
approved these changes
Apr 2, 2021
|
TY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a cosmetic change that renames
Stripe.configurationtojust
Stripe.config. We use the shorter "config" in most other placesincluding
StripeClient#config, so I feel that this is overall moreconsistent.
This change is backwards compatible because the new accessor came in
with #968, and that hasn't been given a formal release yet.
I've left the class name as
StripeConfigurationwhich IMO is fine. Theclass uses the expanded form of the name while vars and accessors use
the shorter
config. Also,StripeConfigurationhas been around alittle bit longer, so renaming it is somewhat backwards incompatible
too.
r? @richardm-stripe This one's pretty tiny. Mind taking a look?