Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value of Customer#delete_discount #964

Merged
merged 1 commit into from Feb 9, 2021

Commits on Feb 8, 2021

  1. Fix return value of Customer#delete_discount

    `Customer#delete_discount` has been broken for some time in that it
    tries to re-initialize `self` (which is a customer) with a received
    discount response. This is incorrect and leads to various problems.
    
    Here, we redefine the return value of `delete_discount` as a discount,
    and have it no longer mutate the object on which is was called. We add a
    comment as well just to help flag some of the behavior which could
    potentially be confusing.
    
    Fixes #963.
    brandur committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    b2c3b92 View commit details
    Browse the repository at this point in the history