Add support for the Issuing Dispute Submit API #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the tests had to be changed/mocked because stripe-mock has a bug where the includable sub-lists it returns have the wrong url set. Because of this, when you call create/list/etc. on one of those sub-lists the calls fails due to that URL being incorrect. Moved one test to use charge+refund (auto-expanded) and another used a mock to have the right URL returned.
brandur-stripe
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is to add the new
/v1/issuing/disputes/idp_123/submitendpoint but the tests needed to be fixed due to an ongoing stripe-mock issue around includable sub-lists.Assigning to Brandur for familiarity with stripe-ruby and the current bug discussed in stripe-mock
r? @brandur-stripe
cc @stripe/api-libraries